From 485f578913e48c39e5ce405ecafeca57f73c2a42 Mon Sep 17 00:00:00 2001 From: Vinicius Moreira Date: Tue, 2 Mar 2021 13:11:02 -0300 Subject: [PATCH] [ui] improvement -> checking if the internet connection is available before proceeding with the upgrade process --- CHANGELOG.md | 2 +- bauh/view/qt/thread.py | 13 +++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 45ec5f6f..c2c3a254 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [0.9.15] 2021 ### Improvements - UI - - checking if internet connection is available before trying to upgrade the selected packages + - checking if the internet connection is available before trying to upgrade the selected packages ### Fixes - AppImage diff --git a/bauh/view/qt/thread.py b/bauh/view/qt/thread.py index 01d66580..aadb4758 100644 --- a/bauh/view/qt/thread.py +++ b/bauh/view/qt/thread.py @@ -388,12 +388,14 @@ class UpgradeSelected(AsyncAction): except: traceback.print_exc() + def _handle_internet_off(self): + self.pkgs = None + self.print(self.i18n['internet.required']) + self.notify_finished({'success': False, 'updated': 0, 'types': set(), 'id': None}) + def run(self): if not self.internet_checker.is_available(): - self.pkgs = None - self.print(self.i18n['internet.required']) - self.notify_finished({'success': False, 'updated': 0, 'types': set(), 'id': None}) - return + return self._handle_internet_off() root_user = user.is_root() to_update, upgrade_requires_root, bkp_supported = [], False, False @@ -472,6 +474,9 @@ class UpgradeSelected(AsyncAction): self.pkgs = None return + if not self.internet_checker.is_available(): + return self._handle_internet_off() + self.change_substatus('') app_config = CoreConfigManager().get_config()