spalencsar/bearhub
1
0
Fork 0
mirror of https://github.com/spalencsar/bearhub.git synced 2026-07-09 08:44:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

[api] improvement: SoftwareManager.get_screenshots returning a generator instead of a list

Browse Source
This commit is contained in:
Vinicius Moreira
2022-02-24 10:32:20 -03:00
parent b2fb656dc0
commit 5a1269d07f
9 changed files with 23 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
bauh/gems/snap/controller.py
View File

@@ -2,7 +2,7 @@ import re
import time
import traceback
from threading import Thread
from typing import List, Set, Type, Optional, Tuple
from typing import List, Set, Type, Optional, Tuple, Generator
from bauh.api.abstract.controller import SoftwareManager, SearchResult, ApplicationContext, UpgradeRequirements, \
TransactionResult, SoftwareAction
@@ -440,8 +440,9 @@ class SnapManager(SoftwareManager):
self.logger.info(f"Running '{pkg.name}': {cmd}")
snap.run(cmd)
def get_screenshots(self, pkg: SnapApplication) -> List[str]:
return pkg.screenshots if pkg.has_screenshots() else []
def get_screenshots(self, pkg: SnapApplication) -> Generator[str, None, None]:
if pkg.screenshots:
yield from pkg.screenshots
def get_settings(self, screen_width: int, screen_height: int) -> Optional[ViewComponent]:
snap_config = self.configman.get_config()