spalencsar/bearhub
1
0
Fork 0
mirror of https://github.com/spalencsar/bearhub.git synced 2026-07-07 20:54:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

[api] improvement: SoftwareManager.get_screenshots returning a generator instead of a list

Browse Source
This commit is contained in:
Vinicius Moreira
2022-02-24 10:32:20 -03:00
parent b2fb656dc0
commit 5a1269d07f
9 changed files with 23 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bauh/view/core/controller.py
View File

@@ -520,11 +520,11 @@ class GenericSoftwareManager(SoftwareManager):
self.logger.info(f'Launching {pkg}')
man.launch(pkg)
def get_screenshots(self, pkg: SoftwarePackage):
def get_screenshots(self, pkg: SoftwarePackage) -> Generator[str, None, None]:
man = self._get_manager_for(pkg)
if man:
return man.get_screenshots(pkg)
yield from man.get_screenshots(pkg)
def get_working_managers(self):
return [m for m in self.managers if self._can_work(m)]

2
bauh/view/qt/thread.py
View File

@@ -1066,7 +1066,7 @@ class ShowScreenshots(AsyncAction):
def run(self):
if self.pkg:
self.notify_finished({'pkg': self.pkg, 'screenshots': self.manager.get_screenshots(self.pkg.model)})
self.notify_finished({'pkg': self.pkg, 'screenshots': tuple(self.manager.get_screenshots(self.pkg.model))})
self.pkg = None