[view] improvement: only displaying a confirmation dialog for custom actions that start immediately

This commit is contained in:
Vinicius Moreira
2021-12-15 15:55:41 -03:00
parent 98e19ea934
commit 9f13b0efd5
3 changed files with 9 additions and 2 deletions

View File

@@ -1422,7 +1422,8 @@ class ManageWindow(QWidget):
self.progress_bar.setValue(value)
def begin_execute_custom_action(self, pkg: Optional[PackageView], action: CustomSoftwareAction):
if pkg is None and not ConfirmationDialog(title=self.i18n['confirmation'].capitalize(),
if pkg is None and action.requires_confirmation and \
not ConfirmationDialog(title=self.i18n['confirmation'].capitalize(),
body='<p>{}</p>'.format(self.i18n['custom_action.proceed_with'].capitalize().format(bold(self.i18n[action.i18n_label_key]))),
icon=QIcon(action.icon_path) if action.icon_path else QIcon(resource.get_path('img/logo.svg')),
i18n=self.i18n).ask():