From c718fe0a3679855dec058138d1e33638467201e1 Mon Sep 17 00:00:00 2001 From: Vinicius Moreira Date: Fri, 28 Jan 2022 19:24:50 -0300 Subject: [PATCH] [view.qt.settings] fix: confirmation dialog icon when launched alone --- CHANGELOG.md | 3 +++ bauh/view/qt/dialog.py | 10 ++++++---- bauh/view/qt/settings.py | 9 ++++++--- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ad0c604d..3015b5b2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - not informing all the provided packages on the transaction context to the dependency sorting algorithm (could lead to a wrong installation order) - not displaying all possible AUR providers for a given dependency +- UI: + - settings panel: confirmation dialog icon when launched alone + ### UI - new logo by [DN-debug](https://github.com/DN-debug) - new dark theme (**knight**) based on Kimi-dark gtk by [DN-debug](https://github.com/DN-debug) diff --git a/bauh/view/qt/dialog.py b/bauh/view/qt/dialog.py index 2de9973c..e69d05e9 100644 --- a/bauh/view/qt/dialog.py +++ b/bauh/view/qt/dialog.py @@ -33,7 +33,8 @@ class ConfirmationDialog(QDialog): def __init__(self, title: str, body: Optional[str], i18n: I18n, icon: QIcon = QIcon(resource.get_path('img/logo.svg')), widgets: Optional[List[QWidget]] = None, confirmation_button: bool = True, deny_button: bool = True, - window_cancel: bool = False, confirmation_label: Optional[str] = None, deny_label: Optional[str] = None): + window_cancel: bool = False, confirmation_label: Optional[str] = None, deny_label: Optional[str] = None, + confirmation_icon: bool = True): super(ConfirmationDialog, self).__init__() if not window_cancel: @@ -64,9 +65,10 @@ class ConfirmationDialog(QDialog): container_body.setLayout(QHBoxLayout()) self.layout().addWidget(container_body) - lb_icon = QLabel() - lb_icon.setObjectName("confirm_dialog_icon") - container_body.layout().addWidget(lb_icon) + if confirmation_icon: + lb_icon = QLabel() + lb_icon.setObjectName("confirm_dialog_icon") + container_body.layout().addWidget(lb_icon) if body: lb_msg = QLabel(body) diff --git a/bauh/view/qt/settings.py b/bauh/view/qt/settings.py index 150431c2..f3d89ce6 100644 --- a/bauh/view/qt/settings.py +++ b/bauh/view/qt/settings.py @@ -110,9 +110,12 @@ class SettingsWindow(QWidget): if success: if not self.window: - dialog.show_message(title=self.i18n['success'].capitalize(), - body=self.i18n['settings.changed.success.warning'], - type_=MessageType.INFO) + ConfirmationDialog(title=self.i18n['success'].capitalize(), + body=f"

{self.i18n['settings.changed.success.warning']}

", + i18n=self.i18n, + confirmation_label=self.i18n['ok'], + confirmation_icon=False, + deny_button=False).ask() QCoreApplication.exit() elif ConfirmationDialog(title=self.i18n['warning'].capitalize(), body=f"

{self.i18n['settings.changed.success.warning']}

"