From dfe23df4b69718c9a69bc19e935f472ab6c50377 Mon Sep 17 00:00:00 2001 From: Vinicius Moreira Date: Tue, 15 Oct 2019 16:49:00 -0300 Subject: [PATCH] [appimage] showing an error dialog when it was not possible to download the file --- README.md | 6 ------ bauh/gems/appimage/controller.py | 4 ++++ bauh/gems/appimage/resources/locale/en | 3 ++- bauh/gems/appimage/resources/locale/es | 3 ++- bauh/gems/appimage/resources/locale/pt | 3 ++- bauh/view/qt/window.py | 2 +- 6 files changed, 11 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index ad81613b..eedca088 100644 --- a/README.md +++ b/README.md @@ -36,12 +36,6 @@ This project has an official Twitter account ( **@bauh4linux** ) so people can s - **libappindicator3**: for the **tray mode** in GTK3 desktop environments - [**fuse**](https://github.com/libfuse/libfuse) may be required to run AppImages on your system. -- There are some issues to work with AppImages in **Ubuntu** based distros. Installing the following packages can help **bauh** to work with them: -``` - binfmt-support - qemu - qemu-user-static -``` ### Distribution diff --git a/bauh/gems/appimage/controller.py b/bauh/gems/appimage/controller.py index ce5a78cc..495676cd 100644 --- a/bauh/gems/appimage/controller.py +++ b/bauh/gems/appimage/controller.py @@ -336,6 +336,10 @@ class AppImageManager(SoftwareManager): watcher.show_message(title=self.i18n['error'], body='Could extract content from {}'.format(bold(file_name)), type_=MessageType.ERROR) + else: + watcher.show_message(title=self.i18n['error'], + body=self.i18n['appimage.install.download.error'].format(bold(pkg.url_download)), + type_=MessageType.ERROR) handler.handle(SystemProcess(new_subprocess(['rm', '-rf', out_dir]))) return False diff --git a/bauh/gems/appimage/resources/locale/en b/bauh/gems/appimage/resources/locale/en index 4dbcfc2d..e8a04789 100644 --- a/bauh/gems/appimage/resources/locale/en +++ b/bauh/gems/appimage/resources/locale/en @@ -14,4 +14,5 @@ appimage.downgrade.impossible.body={} has only one published version. appimage.downgrade.unknown_version.body=It was not possible to identify {} current version in its versions history appimage.downgrade.first_version={} is in its first published version appimage.error.uninstall_current_version=It was not possible to uninstall the current version of {} -appimage.downgrade.install_version=It was not possible to install the version {} ({}) \ No newline at end of file +appimage.downgrade.install_version=It was not possible to install the version {} ({}) +appimage.install.download.error=It was not possible to download the file {}. The file server can be down. \ No newline at end of file diff --git a/bauh/gems/appimage/resources/locale/es b/bauh/gems/appimage/resources/locale/es index 09ee2995..ab80dbbe 100644 --- a/bauh/gems/appimage/resources/locale/es +++ b/bauh/gems/appimage/resources/locale/es @@ -14,4 +14,5 @@ appimage.downgrade.impossible.body={} solo tiene una versión publicada. appimage.downgrade.unknown_version.body=No fue posible identificar la versión actual de {} en su historial de versiones appimage.downgrade.first_version={} está en su primera versión publicada appimage.downgrade.uninstall_current_version=No fue posible desinstalar la versión actual de {} -appimage.downgrade.install_version=No fue posible instalar la versión {} ({}) \ No newline at end of file +appimage.downgrade.install_version=No fue posible instalar la versión {} ({}) +appimage.install.download.error=No fue posible descargar el archivo {}. El servidor del archivo puede estar inactivo. \ No newline at end of file diff --git a/bauh/gems/appimage/resources/locale/pt b/bauh/gems/appimage/resources/locale/pt index e7e43932..1f41b7dc 100644 --- a/bauh/gems/appimage/resources/locale/pt +++ b/bauh/gems/appimage/resources/locale/pt @@ -14,4 +14,5 @@ appimage.downgrade.impossible.body={} tem somente uma versão publicada. appimage.downgrade.unknown_version.body=Não foi possível identificar a versão atual de {} no seu histórico de versões appimage.downgrade.first_version={} se encontra em sua primeira versão publicada appimage.downgrade.uninstall_current_version=Não foi possível desinstalar a versão atual de {} -appimage.downgrade.install_version=Não foi possivel instalar a versão {} ({}) \ No newline at end of file +appimage.downgrade.install_version=Não foi possivel instalar a versão {} ({}) +appimage.install.download.error=Não foi possível baixar o arquivo {}. O servidor do arquivo pode estar fora do ar. \ No newline at end of file diff --git a/bauh/view/qt/window.py b/bauh/view/qt/window.py index 5eb590c3..71c1c6b8 100755 --- a/bauh/view/qt/window.py +++ b/bauh/view/qt/window.py @@ -807,7 +807,7 @@ class ManageWindow(QWidget): def finish_action(self): self.ref_combo_styles.setVisible(True) self.thread_animate_progress.stop = True - self.thread_animate_progress.wait() + self.thread_animate_progress.wait(msecs=1000) self.ref_progress_bar.setVisible(False) self.progress_bar.setValue(0) self.progress_bar.setTextVisible(False)