spalencsar/bearhub
1
0
Fork 0
mirror of https://github.com/spalencsar/bearhub.git synced 2026-07-06 22:54:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

[view.qt] fix: not handling download exceptions

Browse Source
This commit is contained in:
Vinicius Moreira
2023-12-14 14:15:56 -03:00
parent 5a01087f00
commit e44db92a1d
1 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
bauh/view/qt/screenshots.py
View File

@@ -1,4 +1,5 @@
import logging
import traceback
from io import BytesIO
from threading import Thread
from typing import List, Dict
@@ -150,9 +151,20 @@ class ScreenshotsDialog(QDialog):
self.bt_back.setEnabled(self.img_idx != 0)
self.bt_next.setEnabled(self.img_idx != len(self.screenshots) - 1)
def _handle_download_exception(self, idx: int, url: str):
self.logger.error(f"Unexpected exception while downloading screenshot from '{url}'")
traceback.print_exc()
self.loaded_imgs.append(self.i18n["screenshots.download.no_response"])
self._load_img(idx)
def _download_img(self, idx: int, url: str):
self.logger.info(f"Downloading image [{idx}] from {url}")
res = self.http_client.get(url=url, stream=True)
try:
res = self.http_client.get(url=url, stream=True)
except Exception:
self._handle_download_exception(idx, url)
return
if not res:
self.logger.info(f"Could not retrieve image [{idx}] from '{url}'")
@@ -174,11 +186,15 @@ class ScreenshotsDialog(QDialog):
byte_stream = BytesIO()
total_downloaded = 0
for data in res.iter_content(chunk_size=1024):
byte_stream.write(data)
total_downloaded += len(data)
self.download_progress[idx] = (total_downloaded / content_length) * 100
self._load_img(idx)
try:
for data in res.iter_content(chunk_size=1024):
byte_stream.write(data)
total_downloaded += len(data)
self.download_progress[idx] = (total_downloaded / content_length) * 100
self._load_img(idx)
except Exception:
self._handle_download_exception(idx, url)
return
self.logger.info(f"Image [{idx}] successfully downloaded ({url})")
pixmap = QPixmap()