spalencsar/bearhub
1
0
Fork 0
mirror of https://github.com/spalencsar/bearhub.git synced 2026-07-07 00:04:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

flake warnings (#304)

Browse Source
This commit is contained in:
Bruno Cabral
2022-12-12 02:44:27 -08:00
committed by GitHub
parent f10a3f1d1a
commit fb4109bd77
67 changed files with 252 additions and 248 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
bauh/gems/web/controller.py
View File

@@ -44,14 +44,14 @@ try:
from bs4 import BeautifulSoup, SoupStrainer
BS4_AVAILABLE = True
except:
except Exception:
BS4_AVAILABLE = False
try:
import lxml
LXML_AVAILABLE = True
except:
except Exception:
LXML_AVAILABLE = False
RE_SEVERAL_SPACES = re.compile(r'\s+')
@@ -99,7 +99,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
else:
return DEFAULT_LANGUAGE_HEADER
except:
except Exception:
return DEFAULT_LANGUAGE_HEADER
def clean_environment(self, root_password: Optional[str], watcher: ProcessWatcher) -> bool:
@@ -115,7 +115,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
if not res:
success = False
except:
except Exception:
watcher.print(traceback.format_exc())
success = False
@@ -189,7 +189,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
try:
utf8_desc = description.encode('iso-8859-1').decode('utf-8')
description = utf8_desc
except:
except Exception:
pass
return description
@@ -416,7 +416,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
self.logger.info("Removing {} installation directory {}".format(pkg.name, pkg.installation_dir))
try:
shutil.rmtree(pkg.installation_dir)
except:
except Exception:
watcher.show_message(title=self.i18n['error'],
body=self.i18n['web.uninstall.error.remove'].format(bold(pkg.installation_dir)),
type_=MessageType.ERROR)
@@ -427,7 +427,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
if os.path.exists(pkg.desktop_entry):
try:
os.remove(pkg.desktop_entry)
except:
except Exception:
watcher.show_message(title=self.i18n['error'],
body=self.i18n['web.uninstall.error.remove'].format(bold(pkg.desktop_entry)),
type_=MessageType.ERROR)
@@ -437,7 +437,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
if os.path.exists(autostart_path):
try:
os.remove(autostart_path)
except:
except Exception:
watcher.show_message(title=self.i18n['error'],
body=self.i18n['web.uninstall.error.remove'].format(bold(autostart_path)),
type_=MessageType.WARNING)
@@ -448,7 +448,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
if config_path and os.path.exists(config_path):
try:
shutil.rmtree(config_path)
except:
except Exception:
watcher.show_message(title=self.i18n['error'],
body=self.i18n['web.uninstall.error.remove'].format(bold(config_path)),
type_=MessageType.WARNING)
@@ -461,7 +461,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
self.logger.info(f"Removing fix file '{fix_path}'")
try:
os.remove(fix_path)
except:
except Exception:
self.logger.error(f"Could not remove fix file '{fix_path}'")
traceback.print_exc()
watcher.show_message(title=self.i18n['error'],
@@ -499,8 +499,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
def get_history(self, pkg: SoftwarePackage) -> PackageHistory:
pass
def _ask_install_options(self, app: WebApplication, watcher: ProcessWatcher, pre_validated: bool) -> Tuple[
bool, List[str]]:
def _ask_install_options(self, app: WebApplication, watcher: ProcessWatcher, pre_validated: bool) -> Tuple[bool, List[str]]:
watcher.change_substatus(self.i18n['web.install.substatus.options'])
max_width = 350
@@ -713,13 +712,13 @@ class WebApplicationManager(SoftwareManager, SettingsController):
self.logger.info('Could not download the icon {}'.format(pkg.icon_url))
else:
return icon_path, res.content
except:
except Exception:
self.logger.error("An exception has happened when downloading {}".format(pkg.icon_url))
traceback.print_exc()
else:
self.logger.warning(
'Could no retrieve the icon {} defined for the suggestion {}'.format(pkg.icon_url, pkg.name))
except:
except Exception:
self.logger.warning(
'An exception happened when trying to retrieve the icon {} for the suggestion {}'.format(pkg.icon_url,
pkg.name))
@@ -814,7 +813,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
self.logger.info(
f"Using custom installation property '{prop}' ({val if val else '<null>'}) for '{url_domain}' "
f"(Electron: {electron_version})")
except:
except Exception:
self.logger.error(
f"Could not set the custom installation property '{prop}' ({val if val else '<null>'}) "
f"for '{url_domain}' (Electron: {electron_version})")
@@ -872,7 +871,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
with open(package_info_path) as f:
package_info_path = json.loads(f.read())
pkg.package_name = package_info_path['name']
except:
except Exception:
self.logger.info("Could not read the the package info from '{}'".format(package_info_path))
traceback.print_exc()
@@ -1024,7 +1023,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
try:
find_url = not app.icon_url or (
app.icon_url and not self.http_client.exists(app.icon_url, session=False))
app.icon_url and not self.http_client.exists(app.icon_url, session=False))
except (requests.exceptions.ConnectionError, requests.exceptions.ConnectTimeout):
find_url = None
@@ -1156,7 +1155,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
shutil.rmtree(ENV_PATH)
if logs:
print('{}[bauh][web] Directory {} deleted{}'.format(Fore.YELLOW, ENV_PATH, Fore.RESET))
except:
except Exception:
if logs:
print('{}[bauh][web] An exception has happened when deleting {}{}'.format(Fore.RED, ENV_PATH,
Fore.RESET))
@@ -1231,7 +1230,7 @@ class WebApplicationManager(SoftwareManager, SettingsController):
try:
self.configman.save_config(config_)
return True, None
except:
except Exception:
return False, [traceback.format_exc()]
def gen_custom_actions(self) -> Generator[CustomSoftwareAction, None, None]:

14
bauh/gems/web/environment.py
View File

@@ -68,14 +68,14 @@ class EnvironmentUpdater:
self.logger.info(f"Removing old NodeJS version installation dir -> {NODE_DIR_PATH}")
try:
shutil.rmtree(NODE_DIR_PATH)
except:
except Exception:
self.logger.error(f"Could not delete old NodeJS version dir -> {NODE_DIR_PATH}")
traceback.print_exc()
return False
try:
os.rename(extracted_file, NODE_DIR_PATH)
except:
except Exception:
self.logger.error(f"Could not rename the NodeJS version file {extracted_file} as {NODE_DIR_PATH}")
traceback.print_exc()
return False
@@ -84,12 +84,12 @@ class EnvironmentUpdater:
self.logger.info(f'Deleting {NODE_MODULES_PATH}')
try:
shutil.rmtree(NODE_MODULES_PATH)
except:
except Exception:
self.logger.error(f"Could not delete the directory {NODE_MODULES_PATH}")
return False
return True
except:
except Exception:
self.logger.error(f'Could not extract {tarf_path}')
traceback.print_exc()
return False
@@ -97,7 +97,7 @@ class EnvironmentUpdater:
if os.path.exists(tarf_path):
try:
os.remove(tarf_path)
except:
except Exception:
self.logger.error(f'Could not delete file {tarf_path}')
def check_node_installed(self, version: str) -> bool:
@@ -152,7 +152,7 @@ class EnvironmentUpdater:
try:
shutil.rmtree(NODE_DIR_PATH)
return self._install_nodejs(version=version, version_url=version_url, watcher=watcher)
except:
except Exception:
self.logger.error(f'Could not delete the dir {NODE_DIR_PATH}')
return False
@@ -246,7 +246,7 @@ class EnvironmentUpdater:
try:
env_timestamp = datetime.fromtimestamp(float(env_ts_str))
except:
except Exception:
self.logger.error(f"Could not parse environment settings file timestamp: {env_ts_str}")
return True

2
bauh/gems/web/nativefier.py
View File

@@ -31,5 +31,3 @@ def is_available() -> bool:
def get_version() -> str:
return run_cmd('{} --version'.format(NATIVEFIER_BIN_PATH), print_error=False, extra_paths=NODE_PATHS)

2
bauh/gems/web/search.py
View File

@@ -60,7 +60,7 @@ class SearchIndexManager:
f.write(yaml.safe_dump(index))
self.logger.info("Search index successfully written at {}".format(SEARCH_INDEX_FILE))
return True
except:
except Exception:
self.logger.error("Could not write the search index to {}".format(SEARCH_INDEX_FILE))
traceback.print_exc()

8
bauh/gems/web/suggestions.py
View File

@@ -69,7 +69,7 @@ class SuggestionsManager:
try:
sugs_timestamp = datetime.fromtimestamp(float(timestamp_str))
except:
except Exception:
self.logger.error(f"Could not parse the cached suggestions file timestamp: {timestamp_str}")
return True
@@ -105,7 +105,7 @@ class SuggestionsManager:
try:
return yaml.safe_load(sugs_str)
except:
except Exception:
self.logger.error("An unexpected exception happened")
traceback.print_exc()
return {}
@@ -147,7 +147,7 @@ class SuggestionsManager:
try:
with open(self._cached_file_path, 'w+') as f:
f.write(yaml.safe_dump(suggestions))
except:
except Exception:
self.logger.error(f"Could write to {self._cached_file_path}")
traceback.print_exc()
return
@@ -157,7 +157,7 @@ class SuggestionsManager:
try:
with open(self._cached_file_ts_path, 'w+') as f:
f.write(str(timestamp))
except:
except Exception:
self.logger.error(f"Could not write to {self._cached_file_ts_path}")
traceback.print_exc()
return

6
bauh/gems/web/worker.py
View File

@@ -59,7 +59,7 @@ class SuggestionsLoader(Thread):
if self.suggestions:
self.taskman.update_progress(self.task_id, 50, self.i18n['web.task.suggestions.saving'])
self.manager.save_to_disk(self.suggestions, timestamp)
except:
except Exception:
self.logger.error("Unexpected exception")
traceback.print_exc()
@@ -67,7 +67,7 @@ class SuggestionsLoader(Thread):
self.taskman.update_progress(self.task_id, 75, None)
try:
self.suggestions_callback(self.suggestions)
except:
except Exception:
self.logger.error("Unexpected exception")
traceback.print_exc()
@@ -125,7 +125,7 @@ class UpdateEnvironmentSettings(Thread):
def run(self):
self.taskman.register_task(self.task_id, self.i18n['web.task.download_settings'], get_icon_path())
self.taskman.update_progress(self.task_id, 1, self.i18n['task.waiting_task'].format(bold(self.create_config.task_name)))
self.taskman.update_progress(self.task_id, 1, self.i18n['task.waiting_task'].format(bold(self.create_config.task_name)))
self.create_config.join()
web_config = self.create_config.config