From fede4fb210ac906179e214199192d21a69146006 Mon Sep 17 00:00:00 2001
From: Vinicius Moreira <vinicius_fmoreira@hotmail.com>
Date: Mon, 31 Aug 2020 10:19:17 -0300
Subject: [PATCH] [flatpak] fix -> not handling empty array API response when
 filling the app data asynchronously

---
 bauh/gems/flatpak/worker.py | 53 ++++++++++++++++++++-----------------
 1 file changed, 28 insertions(+), 25 deletions(-)

diff --git a/bauh/gems/flatpak/worker.py b/bauh/gems/flatpak/worker.py
index 5f581146..fe1e0403 100644
--- a/bauh/gems/flatpak/worker.py
+++ b/bauh/gems/flatpak/worker.py
@@ -47,42 +47,45 @@ class FlatpakAsyncDataLoader(Thread):
                 if res and res.text:
                     data = res.json()
 
-                    if not self.app.version:
-                        self.app.version = data.get('version')
+                    if not data:
+                        self.logger.warning("No data returned for id {} ({})".format(self.app.id, self.app.name))
+                    else:
+                        if not self.app.version:
+                            self.app.version = data.get('version')
 
-                    if not self.app.name:
-                        self.app.name = data.get('name')
+                        if not self.app.name:
+                            self.app.name = data.get('name')
 
-                    self.app.description = data.get('description', data.get('summary', None))
-                    self.app.icon_url = data.get('iconMobileUrl', None)
-                    self.app.latest_version = data.get('currentReleaseVersion', self.app.version)
+                        self.app.description = data.get('description', data.get('summary', None))
+                        self.app.icon_url = data.get('iconMobileUrl', None)
+                        self.app.latest_version = data.get('currentReleaseVersion', self.app.version)
 
-                    if self.app.latest_version and (not self.app.version or not self.app.update):
-                        self.app.version = self.app.latest_version
+                        if self.app.latest_version and (not self.app.version or not self.app.update):
+                            self.app.version = self.app.latest_version
 
-                    if not self.app.installed and self.app.latest_version:
-                        self.app.version = self.app.latest_version
+                        if not self.app.installed and self.app.latest_version:
+                            self.app.version = self.app.latest_version
 
-                    if self.app.icon_url and self.app.icon_url.startswith('/'):
-                        self.app.icon_url = FLATHUB_URL + self.app.icon_url
+                        if self.app.icon_url and self.app.icon_url.startswith('/'):
+                            self.app.icon_url = FLATHUB_URL + self.app.icon_url
 
-                    if data.get('categories'):
-                        cats = []
-                        for c in data['categories']:
-                            cached = self.category_cache.get(c['name'])
+                        if data.get('categories'):
+                            cats = []
+                            for c in data['categories']:
+                                cached = self.category_cache.get(c['name'])
 
-                            if not cached:
-                                cached = self.format_category(c['name'])
-                                self.category_cache.add_non_existing(c['name'], cached)
+                                if not cached:
+                                    cached = self.format_category(c['name'])
+                                    self.category_cache.add_non_existing(c['name'], cached)
 
-                            cats.append(cached)
+                                cats.append(cached)
 
-                        self.app.categories = cats
+                            self.app.categories = cats
 
-                    loaded_data = self.app.get_data_to_cache()
+                        loaded_data = self.app.get_data_to_cache()
 
-                    self.api_cache.add(self.app.id, loaded_data)
-                    self.persist = self.app.supports_disk_cache()
+                        self.api_cache.add(self.app.id, loaded_data)
+                        self.persist = self.app.supports_disk_cache()
                 else:
                     self.logger.warning("Could not retrieve app data for id '{}'. Server response: {}. Body: {}".format(self.app.id, res.status_code, res.content.decode()))
             except: