spalencsar/nas
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Prevent Docker-dependent services when Docker not selected

Browse Source 
- Add dependency check in create_interactive_config
- Docker services (Vaultwarden, Jellyfin, Portainer) only offered when Docker selected
- Update README to clarify Docker requirements
- Prevents 'Docker not installed' errors during installation
This commit is contained in:
Mărcziem ™
2025-10-03 09:00:11 +02:00
parent 660565a1c4
commit 2441155399
2 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@@ -125,12 +125,12 @@ The script guides you through an interactive configuration:
- **Gateway and DNS:** IPv4/IPv6 automatic detection with override capability - **Gateway and DNS:** IPv4/IPv6 automatic detection with override capability
### Service Selection ### Service Selection
- **Docker:** Container platform with Compose plugin - **Docker:** Container platform with Compose plugin (required for Vaultwarden, Jellyfin, Portainer)
- **NFS:** Network File System with IPv6 support - **NFS:** Network File System with IPv6 support
- **Netdata:** System monitoring - **Netdata:** System monitoring
- **Vaultwarden:** Password manager with security hardening - **Vaultwarden:** Password manager with security hardening (requires Docker)
- **Jellyfin:** Media server with modern GPG keys - **Jellyfin:** Media server with modern GPG keys (requires Docker)
- **Portainer:** Docker management with HTTPS - **Portainer:** Docker management with HTTPS (requires Docker)
- **Webmin:** Web-based system administration interface - **Webmin:** Web-based system administration interface
### Security Configuration ### Security Configuration

16
setup.sh
View File

@@ -304,9 +304,19 @@ create_interactive_config() {
save_config "INSTALL_DOCKER" "$(ask_yes_no "Install Docker?" "y" && echo "true" || echo "false")" save_config "INSTALL_DOCKER" "$(ask_yes_no "Install Docker?" "y" && echo "true" || echo "false")"
save_config "INSTALL_NFS" "$(ask_yes_no "Install NFS?" "n" && echo "true" || echo "false")" save_config "INSTALL_NFS" "$(ask_yes_no "Install NFS?" "n" && echo "true" || echo "false")"
save_config "INSTALL_NETDATA" "$(ask_yes_no "Install Netdata monitoring?" "y" && echo "true" || echo "false")" save_config "INSTALL_NETDATA" "$(ask_yes_no "Install Netdata monitoring?" "y" && echo "true" || echo "false")"
save_config "INSTALL_VAULTWARDEN" "$(ask_yes_no "Install Vaultwarden password manager?" "n" && echo "true" || echo "false")"
save_config "INSTALL_JELLYFIN" "$(ask_yes_no "Install Jellyfin media server?" "n" && echo "true" || echo "false")" # Docker-dependent services
save_config "INSTALL_PORTAINER" "$(ask_yes_no "Install Portainer Docker management?" "n" && echo "true" || echo "false")" if [[ "${INSTALL_DOCKER:-false}" == "true" ]]; then
save_config "INSTALL_VAULTWARDEN" "$(ask_yes_no "Install Vaultwarden password manager?" "n" && echo "true" || echo "false")"
save_config "INSTALL_JELLYFIN" "$(ask_yes_no "Install Jellyfin media server?" "n" && echo "true" || echo "false")"
save_config "INSTALL_PORTAINER" "$(ask_yes_no "Install Portainer Docker management?" "n" && echo "true" || echo "false")"
else
log_warning "Docker not selected - skipping Docker-dependent services (Vaultwarden, Jellyfin, Portainer)"
save_config "INSTALL_VAULTWARDEN" "false"
save_config "INSTALL_JELLYFIN" "false"
save_config "INSTALL_PORTAINER" "false"
fi
save_config "INSTALL_WEBMIN" "$(ask_yes_no "Install Webmin web interface?" "n" && echo "true" || echo "false")" save_config "INSTALL_WEBMIN" "$(ask_yes_no "Install Webmin web interface?" "n" && echo "true" || echo "false")"
log_success "Configuration created and saved to ${CONFIG_FILE}" log_success "Configuration created and saved to ${CONFIG_FILE}"